Fixes for S3 attachments by mdbenito · Pull Request #117 · piceaTech/node-gitlab-2-github

mdbenito · 2021-12-05T11:22:57Z

This PR:

Closes Duplicated attachments in case of throttling #107: uses a hash of the attachment's URL to avoid duplicates upon failure
Closes Cannot migrate MRs with attachments #103: Doesn't fail if there was an error downloading an attachment
Closes The issue file attachment is ignored #106: migrates arbitrary attachment types using a browser cookie (workaround for GitLab's missing API endpoint)
Uses previous attachment URL if S3 is not configured

Fixes for attachments

47ef965

mdbenito marked this pull request as ready for review December 5, 2021 11:24

mdbenito added 3 commits December 5, 2021 15:11

Use browser cookie to download binary attachments from GitLab

8591f52

Allow non-image attachments

6c57383

Fix regex replacement

e754acf

This was referenced Dec 5, 2021

The issue file attachment is ignored #106

Closed

Cannot migrate MRs with attachments #103

Closed

Actually try to leave old URLs in attachments when S3 unavailable

7fac840

spruce reviewed Dec 6, 2021

View reviewed changes

Comment thread src/utils.ts

mdbenito requested a review from spruce December 19, 2021 08:27

spruce approved these changes Dec 27, 2021

View reviewed changes

spruce merged commit c4951e5 into piceaTech:master Dec 27, 2021

mdbenito deleted the fix/117-duplicate-attachments branch January 11, 2022 08:43

Provide feedback