Skip to content

Enable note migration by resolving correct response #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spruce merged 1 commit into from
Dec 14, 2022
Merged

Enable note migration by resolving correct response #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/githubHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,8 +885,8 @@ export class GithubHelper {

try {
// try to create the GitHub pull request from the GitLab issue
await this.githubApi.pulls.create(props);
return Promise.resolve({ data: null }); // need to return null promise for parent to wait on
const response = await this.githubApi.pulls.create(props);
return Promise.resolve(response);
} catch (err) {
if (err.status === 422) {
console.error(
Expand Down