feat(releases): migrate releases from gitlab to github#94
Merged
spruce merged 3 commits intopiceaTech:masterfrom Jan 10, 2022
Merged
feat(releases): migrate releases from gitlab to github#94spruce merged 3 commits intopiceaTech:masterfrom
spruce merged 3 commits intopiceaTech:masterfrom
Conversation
spruce
requested changes
Dec 6, 2021
Member
spruce
left a comment
spruce
left a comment
There was a problem hiding this comment.
Looks good sofar. But I found some things which I would like to be changed.
Also, please add a comment about the new feature to sample settings and the README.
Thanks 👍
Comment on lines
+159
to
+160
|
|
||
|
|
Member
There was a problem hiding this comment.
Could you remove these newlines? :)
| console.error(err); | ||
| } | ||
| } else { | ||
| if (githubRelease) { |
Member
There was a problem hiding this comment.
This if is always true because it is in the else branch of the inverse and can therefor be removed.
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added code to transfer releases from gitlab to github with limited functionality (due to github api limitations).