Updates to permissions and styles #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make permissions more specific for security reasons * Modify colors in style to work with both standard and custom (through Stylish / Stylus) styles
picheli20
requested changes
Jul 10, 2018
app/style.js
Outdated
| z-index: 28; | ||
| width: 280px; | ||
| border: 1px solid #ddd; | ||
| border: 0; |
Owner
There was a problem hiding this comment.
Without the border looks a bit "random" stuff floating, we could add border-radius: 3px; to look like more the GitHub's boxes
Contributor
Author
There was a problem hiding this comment.
I mean I removed the border because from a UX perspective giving it the "box-y" appearance makes interfaces feel more closed off, but I can understand the benefit of it since its a scrollable area and you want to communicate to the user what the container is. The bigger change was to remove the hard-coding of the background-color for the container.
Contributor
Author
|
Updated per comments. |
picheli20
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the sudden nature of this PR, I just figured it was easier to make the small changes and provide the PR than to discuss it and then humbly request to do the PR. Basically, this PR improves the security of the permissions, and also allows more flexible styling with things like Stylus.