WIP Redis support#30
Merged
Merged
Conversation
PicoCreator
commented
Jun 22, 2022
| * @return null if not exists, else a map with the data | ||
| **/ | ||
| public Map<String, Object> DataObjectRemoteDataMap_get(String _oid) { | ||
| RMap<String, String> res = redisson.getMap("_oid"); |
Contributor
Author
There was a problem hiding this comment.
Get the Map as part of the constructor,
Instead of _oid, use the "Table name", to avoid conflict with any existing "Tables"
Your current implementation, only stores 1 map globally, instead of a MAP of MAPS
Contributor
Author
There was a problem hiding this comment.
You can use the following as an analogy
- Redisson : The Database
- getMap : Table
- map.get(id) : Object
Contributor
Author
There was a problem hiding this comment.
We would need to also understand how redisson .getMap extraction will work with redis configured in LRU caching mode (https://redis.io/docs/manual/eviction/)
Which of the following occurs
- individual objects gets evicted (ideal)
- entire collection of objects, tag to a single map (table) gets evicted
- no go : random keys inside an object gets evicted
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
============================================
+ Coverage 57.12% 58.94% +1.82%
- Complexity 1045 1330 +285
============================================
Files 82 88 +6
Lines 5306 6640 +1334
Branches 928 1151 +223
============================================
+ Hits 3031 3914 +883
- Misses 1880 2247 +367
- Partials 395 479 +84
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
… into redis-support
…s-dstack into redis-support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REDIS based support for dataobjectmap