Skip to content

add CuVoodoo org, request ID for CuVoodoo bootloader and BusVoodoo adapter#296

Merged
Arachnid merged 10 commits intopidcodes:masterfrom
cuvoodoo:master
Mar 20, 2018
Merged

add CuVoodoo org, request ID for CuVoodoo bootloader and BusVoodoo adapter#296
Arachnid merged 10 commits intopidcodes:masterfrom
cuvoodoo:master

Conversation

@cuvoodoo
Copy link
Contributor

Add CuVoodoo organisation, request USB ID for CuVoodoo USB DFU bootloader (firmware only) and BusVoodoo multi-protocol debugging adapter (hardware and firmware).

King Kévin added 2 commits January 28, 2018 13:15
…apter

Add CuVoodoo organisation, request USB ID for CuVoodoo USB DFU bootloader (firmware only) and BusVoodoo multi-protocol debugging adapter (hardware and firmware).
@Arachnid
Copy link
Contributor

There's no indication of license in the source code repository. Could you add a license/copying file, please?

@cuvoodoo
Copy link
Contributor Author

Issue fixed: I've added LICENSE.txt files in both firmware/software repositories.
The source files also mention the license at the top.

@cuvoodoo
Copy link
Contributor Author

The CI check failed, but I couldn't see in the CI platform why.
Looking at the CI history the two previous builds also failed. Maybe there is a issue independent of this PR. If this is not the case, could you tell how the build is done or where I overlooked build information?

owner: CuVoodoo
license: CERN OHL v.1.2, GNU GPLv3
site: https://bus.cuvoodoo.info/
source: https://bus.cuvoodoo.info/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please link to the source code here?

@cuvoodoo
Copy link
Contributor Author

cuvoodoo commented Mar 2, 2018

Issue fixed: I set the source link directly to the git repositories

license: GNU GPLv3
site: https://wiki.cuvoodoo.info/doku.php?id=stm32f1xx#usb_dfu
source: https://git.cuvoodoo.info/stm32f1/
--
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing a hyphen here to terminate the metadata block.

@cuvoodoo
Copy link
Contributor Author

Thanks for the review. Issue is now fixed.
Would if be possible to list all my mistakes at once so you don't have to review it so often and I don't have to wait two to three weeks between reviews?

@Arachnid
Copy link
Contributor

I would, but you introduced that typo fixing a previous issue.

@Arachnid Arachnid merged commit 660ae32 into pidcodes:master Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants