SafeWISE CoinWISE request for PID ABBA#360
Merged
Arachnid merged 4 commits intopidcodes:masterfrom Sep 24, 2018
coinwise-io:master
Merged
SafeWISE CoinWISE request for PID ABBA#360Arachnid merged 4 commits intopidcodes:masterfrom coinwise-io:master
Arachnid merged 4 commits intopidcodes:masterfrom
coinwise-io:master
Conversation
Contributor
Author
|
Close pull request because of travis failure. |
Contributor
Author
|
Pull request reopened after fixing travis |
Contributor
|
Sorry to just randomly comment, but what did you do to fix your PR? My PR (#357) failed the Travis build (https://travis-ci.org/pidcodes/pidcodes.github.com/builds/422316693?utm_source=github_status&utm_medium=notification) but it really isn't obvious to me what the problem is... Thanks, --Tom |
Contributor
Author
|
@tom-seddon see my commit 9e3b2db |
Contributor
|
Thanks for the reply. I'll make the same change to my PR and resubmit. --Tom |
Arachnid
approved these changes
Sep 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a request of CoinWISE to use the PID ABBA for the product SafeWISE