Skip to content

Conversation

@janoskut
Copy link
Contributor

@janoskut janoskut commented Apr 3, 2022

Hey, I'm requesting 1209:C12C for the PicoSlave project: https://gitlab.com/janoskut/picoslave.

Thanks!

Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source looks ok. It runs on non-open hardware by a third party.

I'd suggest renaming the project away from the term slave in favor of target to match the latest spec and avoid a loaded term. https://en.wikipedia.org/wiki/I%C2%B2C#Revisions

@janoskut
Copy link
Contributor Author

Thanks for your review and approval @tannewt !

I'd suggest renaming the project away from the term slave in favor of target to match the latest spec and avoid a loaded term. https://en.wikipedia.org/wiki/I%C2%B2C#Revisions

This is amazing news to me, I wasn't aware of recent changes to the terminology of I2C! Unfortunately I'm I afraid that I can't change the project name anymore, as it has made it's name already where we use it.

Is that, or the non-open source hardware a project for getting the open PID?

Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it's fine.

@tannewt tannewt merged commit 13af3a9 into pidcodes:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants