Check frontmatter owners#770
Merged
tannewt merged 7 commits intopidcodes:masterfrom Jan 10, 2023
jepler:check-frontmatter-owners
Merged
Check frontmatter owners#770tannewt merged 7 commits intopidcodes:masterfrom jepler:check-frontmatter-owners
tannewt merged 7 commits intopidcodes:masterfrom
jepler:check-frontmatter-owners
Conversation
.. and make a path more specific while I'm here
* layout is present and "pid" * title, license are present Fix errors in several existing PID files. Also change the output format so that the affected files can be automatically visited by vim when the output of validate_pids is used as the error file.
Contributor
Author
|
@tannewt ping! |
Contributor
I think that (at least used to) be caught by the link checking stuff, althought it seems that was broken, now fixed in #791 but the jekyll build warnings don't get flagged up with test failures which is a bit unfortunate. |
Contributor
Author
|
If this is redundant then please feel free to close it. |
tannewt
approved these changes
Jan 10, 2023
Collaborator
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Looks good to me! Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that not much validation of the metadata is performed. I identified that it would be useful to ensure that the owner's markdown file exists as expected. Other checks, such as for all required keys having values, could be added in the future.