Skip to content

Add Maker badge board#783

Merged
jepler merged 2 commits intopidcodes:masterfrom
dronecz:master
Oct 24, 2022
Merged

Add Maker badge board#783
jepler merged 2 commits intopidcodes:masterfrom
dronecz:master

Conversation

@dronecz
Copy link
Contributor

@dronecz dronecz commented Oct 24, 2022

Thank you for PID/VID for my board.

Copy link
Contributor

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jepler
Copy link
Contributor

jepler commented Oct 24, 2022

There's a problem that needs to be corrected, though. It occurs during the "HTML Proofer" step


- ./_site/1209/2030/index.html
  *  internally linking to /org/Czech maker/, which does not exist (line 78)
     <a href="/org/Czech maker/"></a>

The link needs to exactly match the name of the org file, so remove the space characters and verify the capitalization. Once both steps of the CI are green ✔️ please ping me again so I can merge this.

Fix for merging
@dronecz
Copy link
Contributor Author

dronecz commented Oct 24, 2022

Fixed, thank you @jepler 🙂

@jepler jepler merged commit 433d7de into pidcodes:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants