Skip to content

Conversation

@cnlohr
Copy link
Contributor

@cnlohr cnlohr commented Jul 29, 2023

It would be really helpful if there were 3 basic devices - a bootloader, a HID descriptor and a generic non-HID descriptor for users.

See more about rv003usb here (also referenced in the changed files): https://github.com/cnlohr/rv003usb

  • Update the Bootloader description.
  • Add generic HID for rv003usb project.
  • Add generic USB device for rv003usb project.

* Add generic HID for rv003usb project.
* Add generic USB device for rv003usb project.
Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why rely on serial to differentiate projects?

It seems to me that you really want to use the test PIDs for example code. Actual products should use their own PIDs.

@cnlohr
Copy link
Contributor Author

cnlohr commented Aug 2, 2023

I would not want a separate PID for each example within my project. There may be 10 or 15 before I'm done with this!

In general, I think it's fine, because it doesn't matter if there are multiple of the same VID/PID's that are identical when it comes to HID dongles plugged into the same system.

And it doesn't matter if there are multiple of the same for devices that are being used by bespoke code through HIDAPI.

Would it really be preferential for me to make another 5 PIDs right now?

@tannewt
Copy link
Collaborator

tannewt commented Aug 25, 2023

Why not use test PIDs for example code?

@cnlohr
Copy link
Contributor Author

cnlohr commented Aug 29, 2023

@tannewt I don't understand the question. Please elaborate, test codes meaning what?

@tannewt
Copy link
Collaborator

tannewt commented Oct 16, 2023

@tannewt I don't understand the question. Please elaborate, test codes meaning what?

https://pid.codes/1209/0001/ 0001 - 0010 are private use test codes.

Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I've allowed the CH55 folks to have generic IDs for different descriptor combos. So, I think these are ok. However, I wouldn't suggest differentiating devices over serial. Different fixed devices should use different PIDs, not a custom user land implementation. So, please remove that portion of the comments.

@cnlohr
Copy link
Contributor Author

cnlohr commented Nov 23, 2023

Bleh sorry I missed this for so long. I fixed the comment.

@cnlohr cnlohr closed this Nov 23, 2023
cnlohr added a commit to cnlohr/pidcodes.github.com that referenced this pull request Nov 23, 2023
* Add generic USB device for rv003usb project.

This originally was part of PR pidcodes#869, but it was better to just make a clean PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants