Skip to content

fix(trailing-zeros): Skip LaTeX-to-AST and AST-to-MathJS conversions for numeric equality checks PD-4410 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarlaCostea merged 3 commits into from
Dec 12, 2024
Merged

fix(trailing-zeros): Skip LaTeX-to-AST and AST-to-MathJS conversions for numeric equality checks PD-4410 #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee03a6f
wip and tests for PD-4410
CarlaCostea Dec 10, 2024
20e1725
fix(trailing-zeros): Skip LaTeX-to-AST and AST-to-MathJS conversions …
CarlaCostea Dec 12, 2024
4393169
cleanup
CarlaCostea Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 78 additions & 0 deletions src/fixtures/latex-equal/symbolic/faiil_cases_trailing_zerosPD-4410.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
export default {
mode: "symbolic",
tests: [
{
target: "12.35",
eq: [
"12.350", "12.350000",
],
},
{
target: "10.2",
eq: [
"10.20",
],
},
{
target: "5.05",
eq: [
"5.050",
],
},
{
target: "5.4",
eq: [
"5.40000",
],
},
{
target: "3.3",
eq: [
"3.300",
],
},
{
target: "0.004",
eq: [
"0.0040",
],
},
{
target: "5.7",
eq: [
"5.70",
],
},
{
target: "23.598",
eq: [
"23.5980",
],
},
{
target: "0.00278",
eq: [
"0.002780",
],
},
{
target: "32.279",
eq: [
"32.2790",
],
},
{
target: "0.65",
eq: [
"0.650",
],
},
{
target: "45.3",
eq: [
"45.300",
],
},
],
};

72 changes: 72 additions & 0 deletions src/fixtures/latex-equal/symbolic/success_cases_trailing_zerosPD-4410.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
export default {
mode: "symbolic",
tests: [
{
target: "5.5",
eq: [
"5.50", "5.50000",
],
},
{
target: "15",
eq: [
"15.000",
],
},
{
target: "\\frac{5}{4}",
eq: [
"1.25000",
],
},
{
target: "45",
eq: [
"45.00",
],
},
{
target: "-45.3",
eq: [
"-45.300",
],
},
{
target: "11.25",
eq: [
"11.250", "11.2500",
],
},
{
target: "11.25x",
eq: [
"11.2500x",
],
},
{
target: "0.75",
eq: [
"0.750",
],
},
{
target: "16",
eq: [
"16.00",
],
},
{
target: "1.30",
eq: [
"1.300",
],
},
{
target: "8",
eq: [
"8.0",
],
},
],
};

12 changes: 12 additions & 0 deletions src/latex-equal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ const lta = new LatexToAst();
const atm = new AstToMathJs();

export const latexEqual = (a: Latex, b: Latex, opts: Opts) => {
const isNumeric = (str: string): boolean => /^-?\d+(\.\d+)?$/.test(str);

if (!a || !b) {
return false;
}
Expand All @@ -25,6 +27,16 @@ export const latexEqual = (a: Latex, b: Latex, opts: Opts) => {
return true;
}

if (opts.mode === "symbolic" && isNumeric(a) && isNumeric(b)) {
const numA = parseFloat(a);
const numB = parseFloat(b);

if (numA === numB) {

return true;
}
}

const al = lta.convert(a);
const bl = lta.convert(b);

Expand Down