Skip to content

Conversation

@edeustace
Copy link
Contributor

@edeustace edeustace commented Nov 7, 2016

This adds some simple validation to pack-question and serve-question.

  • checks that the config.json is present
  • checks that dependencies.json is present
  • checks that index.html is present
  • validates config.json with 1 base schema that checks for pies: [ { pie: { name: version: }}] and then validates the individual pies with the schema located in $pie/docs/schema/config.json.

The command will fail if any of the above checks fail.

original notes

When we run pack-question or serve-question we should first check that:

  1. the files are where we expect to find them
  2. the config.json has the correct structure
  3. the dependencies.json has the correct structure
  4. the html file is present (check for instance declarations too?)

@edeustace edeustace added this to the 1.3.0 milestone Oct 14, 2016
@edeustace edeustace modified the milestones: 1.3.0, 1.4.0 Nov 4, 2016
@edeustace edeustace self-assigned this Nov 7, 2016
@edeustace edeustace changed the base branch from master to develop November 7, 2016 12:39
@edeustace edeustace merged commit c545ced into develop Nov 8, 2016
@edeustace edeustace deleted the issues/19-question-validation branch November 8, 2016 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants