-
Notifications
You must be signed in to change notification settings - Fork 14
Added ability to pass in (url encoded) blueprints using bp query parameter #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@piebro as discussed, I added a simple HTML file just for viewing the blueprint. It also takes in the blueprint via a |
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.2/codemirror.min.css"> | ||
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.2/theme/monokai.min.css"> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.2/codemirror.min.js"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.2/mode/javascript/javascript.min.js"></script> | ||
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.2/addon/lint/lint.min.css"> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.2/addon/lint/lint.min.js"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.2/addon/lint/json-lint.min.js"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/jsonlint/1.6.0/jsonlint.min.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are not needed here
|
This looks good. I think this should also be documented in the README somewhere and maybe a link where people can encode a Blueprint, e.g. https://meyerweb.com/eric/tools/dencoder/ or this can also be a small extra website, I think either way is good. I tested it for example with: bp=0eJyd1M1qwzAMAOB30dktcf5W59jXGGUkrRiGRAm2uzaEvPvkdbAxdxD7FMeRPoEdaYGuv%2BJkNDloFtDnkSw0rwtY%2FU5t7%2FfcPCE0YPCseSGA2sG%2FO9OSnUbjdh32DlYBmi54h0auJwFITjuND%2Bt5hoBptBw0kq%2FCiTu5rwTMvMj2FXsXzTUf37NvcX6j69Ch8VVEAiz%2FwmUA5zFwFgEXEXCMW0a4%2Fx%2FEIXCrFDe4udCtE9wN7EsCG5yCzAP3kHBtW1yV8p9tgWWW0hqB%2FKTlknpuSy%2FnfmRohwPDP%2FNIwAca%2B5VT1bkqleJHoYqahb7lshx9%2FBV94xp%2B4JzW9RNuVpWmI added two comment. |
| <script defer data-domain="piebro.github.io/factorio-blueprint-visualizer" src="https://plausible.io/js/plausible.js"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/pako/2.1.0/pako.min.js"></script> | ||
| <!-- for deflating the blueprint string --> | ||
| <script src="website/startExampleBlueprintString.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this and expect that bp is set, otherwise maybe show a small text that no blueprint is set
Fixes #6