Skip to content

ran tests before PRs to check functionality#368

Merged
bishoy-at-pieces merged 8 commits intomainfrom
run-test-ci
Jul 25, 2025
Merged

ran tests before PRs to check functionality#368
bishoy-at-pieces merged 8 commits intomainfrom
run-test-ci

Conversation

@bishoy-at-pieces
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings July 23, 2025 17:27

This comment was marked as outdated.

@bishoy-at-pieces bishoy-at-pieces force-pushed the run-test-ci branch 15 times, most recently from 378fcbf to 55b6edd Compare July 23, 2025 19:27
@bishoy-at-pieces bishoy-at-pieces force-pushed the run-test-ci branch 3 times, most recently from 2e882d8 to 6e79117 Compare July 23, 2025 20:18
@bishoy-at-pieces bishoy-at-pieces force-pushed the run-test-ci branch 6 times, most recently from 8183b51 to 95bf102 Compare July 23, 2025 21:16

This comment was marked as outdated.

@tsavo-at-pieces
Copy link
Contributor

Approved - will proceed to comprehensive review on main!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances test infrastructure before PRs by adding comprehensive shell completion tests and fixing platform-specific file handling issues. The changes primarily focus on testing completions for multiple shells and improving the robustness of existing tests.

Key Changes:

  • Added comprehensive shell completion test suite for Fish, Bash, Zsh, and PowerShell
  • Fixed Windows file locking issues by properly closing file handlers in logger tests
  • Added GitHub Actions workflow for automated testing across platforms
  • Improved MCP gateway test reliability and skipped problematic tests

Reviewed Changes

Copilot reviewed 25 out of 26 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/test_logger.py Added file handler cleanup to prevent Windows file locking issues
tests/completion_tests/ Complete new test suite for shell completions with platform-specific testers
tests/mcps/mcp_gateway_test.py Improved connection checking method
tests/mcps/mcp_gateway_e2e_test.py Simplified JSON formatting and skipped problematic test
.github/workflows/run_tests.yaml New CI workflow for cross-platform testing
tests/conftest.py Added global headless mode fixture
pyproject.toml Added pytest configuration
Comments suppressed due to low confidence (7)

tests/completion_tests/test_powershell.py:253

  • The file ends without a newline character, which violates common coding standards. Add a newline at the end of the file.
            pytest.skip("PowerShell completion not working on Windows")

tests/completion_tests/test_fish.py:186

  • The file ends without a newline character, which violates common coding standards. Add a newline at the end of the file.
        assert len(completions) > 0, "No completions returned"

tests/completion_tests/test_bash.py:167

  • The file ends without a newline character, which violates common coding standards. Add a newline at the end of the file.
        assert len(completions) > 0, "No completions returned on Unix system"

tests/completion_tests/powershell_tester.py:131

  • The file ends without a newline character, which violates common coding standards. Add a newline at the end of the file.
                pass

.github/workflows/run_tests.yaml:79

  • The file ends without a newline character, which violates common coding standards. Add a newline at the end of the file.
          poetry run pytest tests/ --maxfail=1 --exitfirst -v

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

@tsavo-at-pieces tsavo-at-pieces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need windows shell deps?

@bishoy-at-pieces bishoy-at-pieces merged commit 4f73621 into main Jul 25, 2025
7 checks passed
@bishoy-at-pieces bishoy-at-pieces deleted the run-test-ci branch July 25, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants