ran tests before PRs to check functionality#368
Merged
bishoy-at-pieces merged 8 commits intomainfrom Jul 25, 2025
Merged
Conversation
3246442 to
fb1b0c8
Compare
fb1b0c8 to
eb64702
Compare
378fcbf to
55b6edd
Compare
55b6edd to
7e16b22
Compare
2e882d8 to
6e79117
Compare
6e79117 to
fdb7f54
Compare
8183b51 to
95bf102
Compare
95bf102 to
faa745b
Compare
7067d41 to
f3526a2
Compare
f3526a2 to
5c9e2d6
Compare
Contributor
|
Approved - will proceed to comprehensive review on main! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances test infrastructure before PRs by adding comprehensive shell completion tests and fixing platform-specific file handling issues. The changes primarily focus on testing completions for multiple shells and improving the robustness of existing tests.
Key Changes:
- Added comprehensive shell completion test suite for Fish, Bash, Zsh, and PowerShell
- Fixed Windows file locking issues by properly closing file handlers in logger tests
- Added GitHub Actions workflow for automated testing across platforms
- Improved MCP gateway test reliability and skipped problematic tests
Reviewed Changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_logger.py | Added file handler cleanup to prevent Windows file locking issues |
| tests/completion_tests/ | Complete new test suite for shell completions with platform-specific testers |
| tests/mcps/mcp_gateway_test.py | Improved connection checking method |
| tests/mcps/mcp_gateway_e2e_test.py | Simplified JSON formatting and skipped problematic test |
| .github/workflows/run_tests.yaml | New CI workflow for cross-platform testing |
| tests/conftest.py | Added global headless mode fixture |
| pyproject.toml | Added pytest configuration |
Comments suppressed due to low confidence (7)
tests/completion_tests/test_powershell.py:253
- The file ends without a newline character, which violates common coding standards. Add a newline at the end of the file.
pytest.skip("PowerShell completion not working on Windows")
tests/completion_tests/test_fish.py:186
- The file ends without a newline character, which violates common coding standards. Add a newline at the end of the file.
assert len(completions) > 0, "No completions returned"
tests/completion_tests/test_bash.py:167
- The file ends without a newline character, which violates common coding standards. Add a newline at the end of the file.
assert len(completions) > 0, "No completions returned on Unix system"
tests/completion_tests/powershell_tester.py:131
- The file ends without a newline character, which violates common coding standards. Add a newline at the end of the file.
pass
.github/workflows/run_tests.yaml:79
- The file ends without a newline character, which violates common coding standards. Add a newline at the end of the file.
poetry run pytest tests/ --maxfail=1 --exitfirst -v
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tsavo-at-pieces
approved these changes
Jul 25, 2025
Contributor
tsavo-at-pieces
left a comment
There was a problem hiding this comment.
Do we not need windows shell deps?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.