Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the CLI configuration system by consolidating scattered JSON config files into a unified structure with proper validation, type safety, and manager classes. It also extracts MCP-related test utilities into a reusable test base class to reduce code duplication.
- Introduces new configuration schemas using Pydantic for validation and type safety
- Consolidates multiple JSON config files (pieces_config.json, mcp_config.json, etc.) into domain-specific managers
- Creates a shared test utility module for MCP tests to eliminate duplicated mock setup code
Reviewed Changes
Copilot reviewed 47 out of 47 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/mcps/utils.py | New shared test utilities module providing MockPiecesClient and MCPTestBase for MCP unit tests |
| tests/mcps/mcp_*_test.py | Updated to use shared test utilities, eliminating duplicated setup code |
| src/pieces/settings.py | Refactored to use new configuration managers instead of direct file operations |
| src/pieces/mcp/integration.py | Updated to use centralized MCP schema and removed local config management |
| src/pieces/config/ | New configuration management package with schemas, managers, and migration utilities |
| src/pieces/core/config_command.py | Removed - functionality moved to ConfigCommand class |
| src/pieces/app.py | Updated to use new config system and migration logic |
bishoy-at-pieces
force-pushed
the
refactor-config-files
branch
10 times, most recently
from
bc6096c to
10ff63f
Compare
bishoy-at-pieces
force-pushed
the
refactor-config-files
branch
from
10ff63f to
0ec3555
Compare
tsavo-at-pieces
approved these changes
Jul 28, 2025
Contributor
tsavo-at-pieces
left a comment
tsavo-at-pieces
left a comment
There was a problem hiding this comment.
Looking good here!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.