fix: Handle WebSocket errors and subscription failures#390
Merged
bishoy-at-pieces merged 2 commits intomainfrom Aug 11, 2025
Merged
fix: Handle WebSocket errors and subscription failures#390bishoy-at-pieces merged 2 commits intomainfrom
bishoy-at-pieces merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses WebSocket error handling and subscription failures in the Pieces copilot functionality. It improves error messaging for failed model subscriptions and adds WebSocket error logging capabilities.
- Adds proper error handling for "FAILED" status responses with specific messaging for subscription requirements
- Implements WebSocket error callback to capture and log connection issues
- Sets model name from configuration during startup to ensure proper model context
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/pieces/settings.py | Removes unused imports and adds model name initialization during startup |
| src/pieces/copilot/ask_command.py | Adds error handling for failed responses and WebSocket connection errors |
Contributor
tsavo-at-pieces
left a comment
tsavo-at-pieces
left a comment
There was a problem hiding this comment.
Have you addressed the GitHub Copilot Review Comments?
Collaborator
Author
|
mb those was debugging prints |
Contributor
tsavo-at-pieces
left a comment
tsavo-at-pieces
left a comment
There was a problem hiding this comment.
This is lookin solid. Thank you @bishoy-at-pieces !
tsavo-at-pieces
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.