Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes connection management issues in the MCP gateway by improving error handling, cleanup coordination, and connection lifecycle management.
- Implements proper async cleanup coordination using events and tasks to prevent race conditions
- Adds thread-safe exception handling for connection errors with automatic cleanup requests
- Refactors connection management to use dedicated tasks with proper cancellation and timeout handling
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/pieces/settings.py | Adds type annotation for headless_mode boolean field |
| src/pieces/mcp/gateway.py | Major refactoring of connection handling with cleanup coordination, exception handlers, and improved error management |
| src/pieces/base_command.py | Simplifies headless mode logic into single line conditional |
| src/pieces/_vendor/pieces_os_client/wrapper/websockets/base_websocket.py | Changes default error handler from print to no-op |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
70749c9 to
79fb7fb
Compare
79fb7fb to
b697b6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.