Switch to generics from dyn-traits for webapp#263
Merged
piercefreeman merged 1 commit intomainfrom Mar 19, 2026
Merged
Conversation
MOZGIII
force-pushed
the
mzg/ws-2026-03-19-drop-webapp-dyn
branch
from
9bc12d3 to
c92d152
Compare
Coverage Report
Compared to |
piercefreeman
added a commit
that referenced
this pull request
Mar 19, 2026
Goes in after #262 and #263 This PR eliminates the use of `async-trait` macro when defining the backend traits. The `async-trait` was useful before we had GAT stabilized in rust; now it's just making things more annoying (cause of its opinionated bounds on futures) and creates overhead (it boxes the futures, forcing an allocation for each async call).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the last instance of dyn-traits use in the backends.