Skip to content

feat(ci): use APP_ENV and MONGO_URI variables for downstream configs #3337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PierreBrisorgueil merged 2 commits into from
Mar 27, 2026
Merged

feat(ci): use APP_ENV and MONGO_URI variables for downstream configs #3337

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76d857f
feat(ci): use APP_ENV and MONGO_URI variables for downstream project …
PierreBrisorgueil Mar 27, 2026
5ca947c
fix(ci): harden MongoDB wait and prefer secrets for MONGO_URI
PierreBrisorgueil Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,16 @@ jobs:
--health-retries=10

env:
DEVKIT_NODE_db_uri: mongodb://mongo:27017/NodeTest
NODE_ENV: ${{ vars.APP_ENV || 'test' }}
Comment thread
PierreBrisorgueil marked this conversation as resolved.
DEVKIT_NODE_db_uri: ${{ secrets.MONGO_URI || vars.MONGO_URI || 'mongodb://mongo:27017/NodeTest' }}

steps:
- uses: actions/checkout@v4

- name: Wait for MongoDB
run: |
timeout 120 bash -c 'until node -e "const uri=process.env.DEVKIT_NODE_db_uri;let host=\"mongo\";let port=27017;try{if(uri){const u=new URL(uri);if(u.hostname)host=u.hostname;if(u.port)port=Number(u.port)||port;}}catch(e){}const s=require(\"net\").createConnection({host,port});s.setTimeout(5000);s.on(\"connect\",()=>{s.end();process.exit(0)});s.on(\"timeout\",()=>{s.destroy();process.exit(1)});s.on(\"error\",()=>process.exit(1))"; do echo "waiting for $DEVKIT_NODE_db_uri..."; sleep 1; done'

Comment thread
PierreBrisorgueil marked this conversation as resolved.
- run: npm ci

- run: npm run lint
Expand Down
Loading