fix(ci): simplify CI.yml — remove ARC-specific conditionals

[PierreBrisorgueil]

Summary

• Remove if: ${{ !vars.RUNNER }} condition from setup-node step (always run it)
• Remove the entire "Wait for MongoDB" step with its complex Node TCP probe — the services health check already guarantees MongoDB is ready

Test plan

• CI passes on this PR (self-validating: the simplified workflow runs successfully)

Closes #3342

Summary by CodeRabbit

• Chores
  • Optimized CI/CD workflow by streamlining build pipeline steps and removing redundant verification processes for more efficient build execution.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: a0c8046e-acde-4ae0-86a3-60d2146e2e20

📥 Commits

Reviewing files that changed from the base of the PR and between 921a706 and bec9eec.

📒 Files selected for processing (1)

• .github/workflows/CI.yml

💤 Files with no reviewable changes (1)

• .github/workflows/CI.yml

---

Walkthrough

Simplified CI workflow by removing runner-specific conditionals and MongoDB readiness checks. Deleted the if: ${{ !vars.RUNNER }} guard from the Setup Node.js step and removed the "Wait for MongoDB" step that performed TCP connection verification.

Changes

Cohort / File(s)	Summary
CI Workflow Simplification .github/workflows/CI.yml	Removed if: ${{ !vars.RUNNER }} conditional guard from the Setup Node.js step to ensure it always runs. Deleted the "Wait for MongoDB" step that contained TCP connection logic for deriving host/port from environment variables. Workflow now executes consistently across all runner types without explicit Mongo readiness verification.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

• fix(ci): simplify CI.yml — remove ARC-specific conditionals Vue#3805 — Also removes the if: ${{ !vars.RUNNER }} conditional from the setup-node step in CI workflow.
• feat(ci): skip setup-node and container when using self-hosted runner #3338 — Addresses CI workflow and self-hosted runner conditionals for the setup-node and MongoDB handling steps.

Possibly related PRs

• feat(ci): use APP_ENV and MONGO_URI variables for downstream configs #3337 — Modifies the MongoDB "Wait for MongoDB" step and related MONGO_URI/NODE_ENV variables in the same CI workflow.
• perf(ci): optimize GitHub Actions — timeout, skip merge push, Node LTS #3329 — Updates the setup-node step configuration (node-version attribute) in .github/workflows/CI.yml.
• feat(ci): add container mode for ARC kubernetes compatibility #3332 — Modifies .github/workflows/CI.yml and alters how Mongo readiness and DEVKIT_NODE_db_uri are handled.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description covers the key changes and test plan, but omits required template sections like Scope, Validation checklist, Guardrails, and Infra details.	Add missing template sections: expand Scope (modules, cross-impact, risk level), complete Validation checklist, address Guardrails checks, and include Before/After comparison if applicable.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: removing ARC-specific conditionals from CI.yml.
Linked Issues check	✅ Passed	All coding requirements from issue #3342 are met: the conditional if: ${{ !vars.RUNNER }} is removed and the Wait for MongoDB step is deleted.
Out of Scope Changes check	✅ Passed	All changes are strictly within scope of issue #3342: only the setup-node conditional and MongoDB wait step were removed, with no extraneous modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/ci-simplify

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR simplifies the GitHub Actions CI workflow by removing ARC/self-hosted-runner-specific conditionals and relying on the MongoDB service health check for readiness.

Changes:

• Always run actions/setup-node (removed if: ${{ !vars.RUNNER }} guard).
• Removed the bespoke “Wait for MongoDB” TCP-probe step, relying on the service --health-cmd instead.