fix(billing): convert cents to units in dispute credit#3625
fix(billing): convert cents to units in dispute credit#3625PierreBrisorgueil merged 1 commit intomasterfrom
Conversation
V8 audit C5: amountCents was passed directly to creditCompensation instead of being converted to meter units. Adds getDollarsToUnitRatio() conversion (default 1000 → 5000 cents = 50,000 units) + audit-trail logging of both amountCents and creditUnits for traceability.
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Fixes billing dispute crediting so creditDisputeReinstated converts amountCents into meter units using config.billing.meter.dollarsToUnitRatio (instead of treating cents as units), and improves audit logging/test coverage around the conversion.
Changes:
- Convert dispute
amountCents→creditUnitsviagetDollarsToUnitRatio()before callingcreditCompensation. - Extend audit log payload to include
creditUnitsalongsideamountCents. - Update/add unit tests to assert the conversion behavior and prevent regressions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| modules/billing/services/billing.admin.service.js | Converts dispute cents to meter units using getDollarsToUnitRatio() and logs creditUnits. |
| modules/billing/tests/billing.admin.service.unit.tests.js | Updates existing assertion for converted units and adds a regression test for cents→units conversion. |
| // Convert cents to meter units using the configured dollarsToUnitRatio. | ||
| const creditUnits = Math.round((amountCents / 100) * getDollarsToUnitRatio()); | ||
| const result = await BillingExtraBalanceRepository.creditCompensation(orgId, creditUnits, refId, reason); |
| // amountCents is used directly as the credit unit — ops chooses the proportional amount. | ||
| const result = await BillingExtraBalanceRepository.creditCompensation(orgId, amountCents, refId, reason); | ||
| // Convert cents to meter units using the configured dollarsToUnitRatio. | ||
| const creditUnits = Math.round((amountCents / 100) * getDollarsToUnitRatio()); |
| // amountCents=2000, default dollarsToUnitRatio=1000 → creditUnits = Math.round((2000/100)*1000) = 20000 | ||
| const expectedCreditUnits = Math.round((amountCents / 100) * 1000); |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3625 +/- ##
=======================================
Coverage 88.82% 88.82%
=======================================
Files 134 134
Lines 4616 4617 +1
Branches 1423 1423
=======================================
+ Hits 4100 4101 +1
Misses 403 403
Partials 113 113
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Summary
creditDisputeReinstatedwas passingamountCentsdirectly tocreditCompensationinstead of converting to meter units viadollarsToUnitRatioMath.round((amountCents / 100) * getDollarsToUnitRatio())conversion (~3 LOC) before thecreditCompensationcallamountCentsandcreditUnitsfor traceability5000 cents = 50,000 unitsat default ratio 1000Test plan
applies credit and returns applied:true + ledgerEntry— now assertscreditCompensationcalled withcreditUnits=20000(not rawamountCents=2000)converts amountCents to creditUnits using dollarsToUnitRatio (V8 audit C5)— asserts5000 cents → 50000 unitsat ratio 1000billing.admin.service.unit.tests.js)