chore(skills): /feature Phase 0.0 — fetch issue body + aged-scope re-validation gate#3929
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughModified the feature skill to fetch ChangesAged-scope re-validation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related issues
Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/skills/feature/SKILL.md:
- Around line 56-64: The aged-scope flow in SKILL.md should not leave a stale
claim marker behind when the user aborts at the re-validation gate. Update the
gate logic around the claim/WIP handling so that the claim step happens only
after the aged-scope check succeeds, or otherwise ensure the existing WIP
comment from the claim flow is also removed when calling the unassign step. Use
the nearby “Aged-scope gate (re-validate before implementing)” section and the
“Proceed to Phase 0” transition to locate the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 32aebda4-2bab-48f3-9e0f-23d3d8459c4d
📒 Files selected for processing (1)
.claude/skills/feature/SKILL.md
…validation gate The claim step read number,title,state,assignees,comments but never the issue body, so the scope written in the description was silently ignored. Add body to the fetch and a re-validation gate: an old issue (or one whose references no longer match the codebase) gets its scope re-checked against current code, with drift presented to the user before implementation. Closes #3928
Removing only the assignee left the WIP — comment behind, which step 2 treats as a resumable claim on the next run.
d401734 to
096c0e9
Compare
What
The Phase 0.0 claim step fetched
number,title,state,assignees,comments— never the issuebody, so the scope written in the description was silently ignored by the executor. It also implemented aged issues as-written even when the referenced code had moved.body+createdAtin the Phase 0.0gh issue viewcall; the body is the primary scope sourcecreatedAt> ~7 days) or references that no longer match the codebase → re-validate scope against current code, present drift before implementing; un-claim on abortDoc-only change to
.claude/skills/feature/SKILL.md.Closes #3928
Summary by CodeRabbit