Skip to content

Use updated theme package to simplify imports of Pierre themes #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdo merged 2 commits into from
Apr 2, 2026
Merged

Use updated theme package to simplify imports of Pierre themes #465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd8cb66
Use updated theme package to simplify imports of Pierre themes
mdo Apr 1, 2026
32cfa12
allow theme package
mdo Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions apps/docs/app/docs/Theming/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,13 @@ export const THEMING_PROJECT_STRUCTURE: ThemingConstant = {
│ ├── palette.ts # Color definitions (edit this!)
│ ├── package-vsix.ts # Generates VS Code/Cursor extension
│ └── theme.ts # Token color mappings
├── themes/ # Generated theme JSON files
├── dist/ # Generated MJS modules (for Shiki)
│ ├── index.mjs
│ ├── pierre-dark.mjs
│ ├── pierre-light.mjs
│ ├── pierre-dark-vibrant.mjs
│ └── pierre-light-vibrant.mjs
├── themes/ # Generated JSON files (for VS Code)
│ ├── pierre-dark.json
│ ├── pierre-light.json
│ ├── pierre-dark-vibrant.json
Expand Down Expand Up @@ -485,14 +491,18 @@ export const THEMING_REGISTER_THEME: ThemingConstant = {
name: 'register-theme.ts',
contents: `import { registerCustomTheme } from '@pierre/diffs';

// Register your theme JSON files before rendering
// The name must match the "name" field in your theme JSON
// Register your theme files before rendering.
// The name must match the "name" field in your theme.

// Option 1: Import from your bundled theme files
// Option 1: Import MJS theme modules (recommended)
registerCustomTheme('my-theme-dark', () => import('my-theme/dark'));
registerCustomTheme('my-theme-light', () => import('my-theme/light'));

// Option 2: Import JSON theme files
registerCustomTheme('my-theme-dark', () => import('./themes/my-theme-dark.json'));
registerCustomTheme('my-theme-light', () => import('./themes/my-theme-light.json'));

// Option 2: Fetch from a URL (for CDN-hosted themes)
// Option 3: Fetch from a URL (for CDN-hosted themes)
registerCustomTheme('my-theme-dark', async () => {
const response = await fetch('/themes/my-theme-dark.json');
return response.json();
Expand Down
4 changes: 2 additions & 2 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion bunfig.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[install]

minimumReleaseAge = 604800 # 7 days in seconds
minimumReleaseAgeExcludes = ["@types/bun"]
minimumReleaseAgeExcludes = ["@types/bun", "@pierre/theme"]
Copy link
Copy Markdown
Contributor

@SlexAxton SlexAxton Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to add "@pierre/icons" here anytime you need to.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"@octokit/rest": "22.0.0",
"@pierre/icons": "0.1.0",
"@pierre/storage": "0.0.10",
"@pierre/theme": "0.0.22",
"@pierre/theme": "0.0.28",
"@playwright/test": "1.51.1",
"@radix-ui/react-avatar": "1.1.10",
"@radix-ui/react-dialog": "1.1.15",
Expand Down
6 changes: 2 additions & 4 deletions packages/diffs/src/highlighter/shared_highlighter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,13 +128,11 @@ export async function disposeHighlighter(): Promise<void> {
}

registerCustomTheme('pierre-dark', async () => {
const m = await import('@pierre/theme/themes/pierre-dark.json');
const theme = (m.default ?? m) as unknown as ThemeRegistrationResolved;
const { default: theme } = await import('@pierre/theme/pierre-dark');
return { ...theme, name: 'pierre-dark' } as ThemeRegistrationResolved;
});

registerCustomTheme('pierre-light', async () => {
const m = await import('@pierre/theme/themes/pierre-light.json');
const theme = (m.default ?? m) as unknown as ThemeRegistrationResolved;
const { default: theme } = await import('@pierre/theme/pierre-light');
return { ...theme, name: 'pierre-light' } as ThemeRegistrationResolved;
});
42 changes: 21 additions & 21 deletions packages/diffs/test/__snapshots__/createFileHeaderElement.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,27 +87,6 @@ exports[`createFileHeaderElement renders default file header AST 1`] = `
}
`;

exports[`createFileHeaderElement renders custom file header AST 1`] = `
{
"children": [
{
"children": [],
"properties": {
"name": "header-custom",
},
"tagName": "slot",
"type": "element",
},
],
"properties": {
"data-change-type": undefined,
"data-diffs-header": "custom",
},
"tagName": "div",
"type": "element",
}
`;

exports[`createFileHeaderElement renders default renamed file header AST 1`] = `
{
"children": [
Expand Down Expand Up @@ -234,3 +213,24 @@ exports[`createFileHeaderElement renders default renamed file header AST 1`] = `
"type": "element",
}
`;

exports[`createFileHeaderElement renders custom file header AST 1`] = `
{
"children": [
{
"children": [],
"properties": {
"name": "header-custom",
},
"tagName": "slot",
"type": "element",
},
],
"properties": {
"data-change-type": undefined,
"data-diffs-header": "custom",
},
"tagName": "div",
"type": "element",
}
`;
Loading