Skip to content

feat(editor): Add rounded selection #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ije merged 8 commits into from
Jun 2, 2026
+320 −176
Merged

feat(editor): Add rounded selection #757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d4c49f9
Update types
ije May 31, 2026
e805f02
Fix selection range rendering
ije May 31, 2026
6bd8a4e
Fix selection range rendering
ije May 31, 2026
a63cd64
Add `roundedSelection` option
ije May 31, 2026
292fc8c
Add jsDocs
ije Jun 1, 2026
e523b65
Use 'editorCursor.foreground' color
ije Jun 1, 2026
ff893c6
Fix
ije Jun 1, 2026
7f639cb
Use parseInt
ije Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions packages/diffs/src/editor/css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
const DEBUG_SELECTION = false;

export const editorCSS: string = /* CSS */ `
::selection {
background-color: ${DEBUG_SELECTION ? 'rgba(255, 0, 0, 0.1)' : 'transparent'};
background-color: transparent;
}
@keyframes blinking {
0% { opacity: 1; }
Expand All @@ -22,7 +20,7 @@ export const editorCSS: string = /* CSS */ `
}
@media (min-width: 480px) {
[data-content] {
caret-color: ${DEBUG_SELECTION ? 'red' : 'transparent'};
caret-color: transparent;
}
[data-quick-edit] {
caret-color: currentColor;
Expand Down Expand Up @@ -66,7 +64,12 @@ export const editorCSS: string = /* CSS */ `
[data-caret] {
width: 2px;
height: 1lh;
background-color: ${DEBUG_SELECTION ? 'transparent' : 'var(--diffs-bg-caret)'};
background-color: var(--diffs-bg-caret-override, var(--diffs-editor-cursor-fg,
light-dark(
color-mix(in lab, var(--diffs-fg) 50%, var(--diffs-bg)),
color-mix(in lab, var(--diffs-fg) 75%, var(--diffs-bg))
))
);
animation: blinking 1.2s infinite;
animation-delay: 0.8s;
visibility: hidden;
Expand All @@ -76,6 +79,23 @@ export const editorCSS: string = /* CSS */ `
z-index: -10;
background-color: var(--diffs-editor-selection-bg);
}
[data-selection-corner] {
width: 100%;
height: 100%;
background-color: var(--diffs-bg);
}
[data-rtl] {
border-top-left-radius: 3px;
}
[data-rtr] {
border-top-right-radius: 3px;
}
[data-rbl] {
border-bottom-left-radius: 3px;
}
[data-rbr] {
border-bottom-right-radius: 3px;
}
[data-editor-overlay] {
display: contents;
}
Expand Down
Loading
Loading