Skip to content

feat(useVModel): Set to throw error if current instance is undefined #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pikax merged 2 commits into from
Mar 25, 2021
Merged

feat(useVModel): Set to throw error if current instance is undefined #819

pikax merged 2 commits into from
Mar 25, 2021

Conversation

@nandi95
Copy link
Contributor

@nandi95 nandi95 commented Mar 24, 2021 •
edited
Loading

closes #818

The docs are still correct, however a note/warning perhaps can be added:

::: warning
This method should only ever be called in the `setup` or lifecycle hook methods.
:::

pikax
pikax approved these changes Mar 25, 2021
View reviewed changes
Copy link
Owner

@pikax pikax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@pikax pikax merged commit f352cf5 into pikax:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pikax pikax pikax approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

useVModel: throw error if instance is not defined.

2 participants

@nandi95 @pikax