feat: add --no-tty flag to run and shell commands#5
Conversation
|
Warning Rate limit exceeded@pilat has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 40 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
WalkthroughAdds a --no-tty flag to run and shell commands, threads the flag into runRun and runShell signatures, and updates TTY selection: flag overrides, run uses scenario.Tty when set then auto-detect, shell falls back to auto-detect. Updates ScenarioConfig.Tty comment to “default: auto-detect.” Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant CLI as devbox CLI
participant Cmd as run/shell handler
participant Cfg as ScenarioConfig (run)
participant TTY as TTY Detector
User->>CLI: devbox run|shell [--no-tty]
CLI->>Cmd: parse flags, call runRun/runShell(..., noTtyFlag)
alt noTtyFlag == true
Cmd->>Cmd: set Tty = false
else noTtyFlag == false
opt run path
Cmd->>Cfg: read scenario.Tty
alt scenario.Tty is set
Cmd->>Cmd: set Tty = scenario.Tty
else
Cmd->>TTY: isTTYAvailable()
TTY-->>Cmd: bool
Cmd->>Cmd: set Tty = result
end
end
opt shell path
Cmd->>TTY: isTTYAvailable()
TTY-->>Cmd: bool
Cmd->>Cmd: set Tty = result
end
end
Cmd-->>User: execute with selected TTY mode
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
Pre-merge checks and finishing touches and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
77431d5 to
4a3b967
Compare
4a3b967 to
87c27f3
Compare
Summary by CodeRabbit
New Features
Refactor
Documentation