Skip to content

Support custom fs (tailing)#100

Closed
ronag wants to merge 2 commits intopillarjs:masterfrom
BoffinsDev:master
Closed

Support custom fs (tailing)#100
ronag wants to merge 2 commits intopillarjs:masterfrom
BoffinsDev:master

Conversation

@ronag
Copy link

@ronag ronag commented Feb 1, 2016

This allows one to provide a custom fs implementation to send with .e.g. tailing (growing) support.

@dougwilson
Copy link
Contributor

Hi @ronag, thanks for your pull request! If you can, please check out the tests, as there are a bunch of failures with these changes.

I also don't see anything about a .growing property in the Node.js documentation: https://nodejs.org/api/fs.html#fs_class_fs_stats what does it mean and where does it come from?

In addition, I'm not sure about this module ever sending back a 202, because it is described as the following in RFC 7231:

The 202 (Accepted) status code indicates that the request has been accepted for processing, but the processing has not been completed. The request might or might not eventually be acted upon, as it might be disallowed when processing actually takes place. There is no facility in HTTP for re-sending a status code from an asynchronous operation.

The 202 response is intentionally noncommittal. Its purpose is to allow a server to accept a request for some other process (perhaps a batch-oriented process that is only run once per day) without requiring that the user agent's connection to the server persist until the process is completed. The representation sent with this response ought to describe the request's current status and point to (or embed) a status monitor that can provide the user with an estimate of when the request will be fulfilled.

To me, that describing the accepting of the given request (i.e. the GET or HEAD request that this module will respond to), rather than indicate that some process is still pending (i.e. that you're checking to see if something is done yet).

@dougwilson
Copy link
Contributor

Hi @ronag, I'm closing this due to no response in over 2 months. If you get back to me on my questions/comments above, I'll happily re-open this pull request!

@dougwilson dougwilson closed this May 24, 2016
bjohansebas pushed a commit to bjohansebas/send that referenced this pull request Jan 21, 2026
Signed-off-by: Frazer Smith <frazer.dev@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants