Skip to content

Add autoEnd option#137

Closed
xdcarter wants to merge 1 commit intopillarjs:masterfrom
xdcarter:master
Closed

Add autoEnd option#137
xdcarter wants to merge 1 commit intopillarjs:masterfrom
xdcarter:master

Conversation

@xdcarter
Copy link
Copy Markdown

@xdcarter xdcarter commented Mar 5, 2017

add option autoEnd to match the raw API pipe from Stream in NodeJS. This option enable append some customized data to the raw file。It make easy to implement BigPipe like function。it also help to add some hook code to handle JS module dependence when downloading JS file async in Dev mode。

@dougwilson
Copy link
Copy Markdown
Contributor

Hi @xdcarter why are you closing and re-opening this PR over and over? It looks identical to #135 which you closed. Are you trying to change some aspect of the PR? I'm not sure how to proceed here, or what I need to wait for from you to change.

@dougwilson dougwilson self-assigned this Mar 5, 2017
@dougwilson dougwilson added the pr label Mar 5, 2017
@xdcarter
Copy link
Copy Markdown
Author

xdcarter commented Mar 5, 2017

sorry, I'm fresh at github,I do need to familiar with flow。I used to create new pr at gitlab in my local office

@dougwilson
Copy link
Copy Markdown
Contributor

I can understand that, but it's identical to #135 . Are you trying to change some aspect of the PR? I'm not sure how to proceed here, or what I need to wait for from you to change.

@xdcarter
Copy link
Copy Markdown
Author

xdcarter commented Mar 5, 2017

would just forget the #135 #136

Copy link
Copy Markdown
Contributor

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but I made a comment with some requested changes, but since you closed it they are gone now. My assumption is that you are trying to make those changes I requested from the first PR. Please make the requested changes.

@xdcarter
Copy link
Copy Markdown
Author

xdcarter commented Mar 6, 2017

Sorry for the confusion caused. Yes, you're right that the previous PR is same with #137. For now, I have nothing to change. Pls go on reviewing my merge request.

@dougwilson
Copy link
Copy Markdown
Contributor

Please make the changes requested in #135 (comment)

@dougwilson
Copy link
Copy Markdown
Contributor

I never heard back and the source repository is gone, which makes it un-mergeable.

@dougwilson dougwilson closed this Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants