PnL Bug Fix

[vignesha22]

Description

• disable spam filter for wallet transactions to include all trades in PnL

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Summary by CodeRabbit

• Bug Fixes
  • Adjusted wallet transaction filtering behavior to include additional transaction types in query results.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

A boolean parameter in the wallet transactions API request was modified, changing filterSpam from true to false to alter the spam-filtering behavior of the query without modifying the endpoint or request structure.

Changes

Cohort / File(s)	Change Summary
API Configuration Update src/services/pillarXApiWalletTransactions.ts	Changed filterSpam boolean flag from true to false in API request body

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

• Single-file, single-parameter configuration change with no logic or structural modifications

Poem

🐰 A flip of the switch, oh what a sight,
From true to false, we change the light,
No spam shall filter, let all flow free,
A tiny toggle sets transactions spree! ✨

Pre-merge checks and finishing touches

❌ Failed checks (2 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'PnL Bug Fix' is vague and generic, lacking specificity about what the actual bug fix entails or which component is affected.	Consider using a more descriptive title like 'Disable spam filter in wallet transactions API to fix PnL calculations' that clearly explains the specific change.
Description check	❓ Inconclusive	The description is incomplete; it lacks testing details and only partially addresses the template requirements.	Add details about how the changes were tested, including the testing environment and specific test cases that verify PnL calculations are now correct.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch remove-spam-filter-pnl

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a0a9fa and b6fb961.

📒 Files selected for processing (1)

• src/services/pillarXApiWalletTransactions.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: unit-tests
• GitHub Check: lint
• GitHub Check: Cloudflare Pages: pillarx-debug

🔇 Additional comments (1)

src/services/pillarXApiWalletTransactions.ts (1)

29-40: Hardcoding filterSpam: false is appropriate for PnL calculation; no refactoring needed

All three call sites of useGetWalletTransactionsQuery (PortfolioTokenList, Sell, Buy) use the transaction data exclusively for PnL calculations via the useTokenPnL hook. There is no general transaction history or wallet activity UI consuming this endpoint, so including spam-filtered trades does not risk degrading other user experiences. The hardcoded filterSpam: false is correct for this specialized use case.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}