Header Announcement for Landing Page#480
Conversation
WalkthroughAdds a header announcement rendered conditionally in the Header component and updates global styles for the announcement (fixed purple color, larger text, and responsive link visibility adjustments). Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
src/components/LandingPage/Header/index.jsx (1)
12-15: Hardcoded announcement config (always on) should be externalizedRight now
show: true+ the full copy/URL are baked into the component, which makes toggling/rotating announcements a code deploy. Consider moving this to config/env/CMS (or at least a module-level constant).src/components/LandingPage/GlobalStyles/index.jsx (2)
280-290: Prefervar(--violet)over repeating#8a77ffThis keeps the announcement color consistent with the theme variables and avoids future drift.
.header__announcement { position: relative; - background: #8a77ff; + background: var(--violet); z-index: 101; } @media only screen and (max-width: 1024px) { .header__announcement { - background: #8a77ff; + background: var(--violet); } }
300-318: Align link selectors (p avs.wrapper a) to avoid unintended stylingYou currently underline via
.header__announcement__wrapper p abut set display via.header__announcement__wrapper aat the breakpoint—worth making consistent so a future extra link doesn’t get unexpected layout rules.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
src/containers/__snapshots__/Main.test.tsx.snapis excluded by!**/*.snap
📒 Files selected for processing (2)
src/components/LandingPage/GlobalStyles/index.jsx(2 hunks)src/components/LandingPage/Header/index.jsx(2 hunks)
🧰 Additional context used
🪛 Biome (2.1.2)
src/components/LandingPage/Header/index.jsx
[error] 52-52: Avoid passing content using the dangerouslySetInnerHTML prop.
Setting content using code can expose users to cross-site scripting (XSS) attacks
(lint/security/noDangerouslySetInnerHtml)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: lint
- GitHub Check: unit-tests
- GitHub Check: Cloudflare Pages: pillarx-debug
Deploying pillarx-debug with
|
| Latest commit: |
37cef4b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4821f169.pillarx-debug.pages.dev |
| Branch Preview URL: | https://chore-header-notification-la.pillarx-debug.pages.dev |
Deploying x with
|
| Latest commit: |
37cef4b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cecf954c.x-e62.pages.dev |
| Branch Preview URL: | https://chore-header-notification-la.x-e62.pages.dev |
Description
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Summary by CodeRabbit
New Features
Style
✏️ Tip: You can customize this high-level summary in your review settings.