tests: extend cmd/cosift coverage round 2#2
Merged
Conversation
…s-file, embed batch
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recallAtKandsummaryfrombench_pq.go, including empty/single/many-element edge cases.truncStrandtruncateForEmbedLiteboundary behaviour.stripPort,numNonEmpty,newRateLimiterFromEnv,rateLimiter.allow/whitelistList,rateLimit,count) and the no-receiver/whitelist/exhaust branches.handleLanding(exact-root + 404),handleChat,handleOpenAPI,handleSwaggerUI,handleSwaggerAsset(CSS/JS/404),handleHealthz,responseRecorder.forwardURLToPeer(happy, 5xx error, full-URL prefix branches) viahttptest.NewServer.batchEmbed/embedWithRetryhappy + multi-batch + non-rate-limit error paths using a fakeembed.Embedder.paraphraseRetriever.generateParaphrasescache hit + chat error path using a fakeembed.ChatClient.handleCheckpoint,handlePQEncode(+ no-HNSW 400),handlePQTrain,handleEmbedBackfill(+ missing-deps 501),handleHNSWCompact,handleFrontierPurgeHost,handleSitemapImport,handleSitePack,handleCrawlEnqueue,handleCrawlNow,handleEvalQuick,handleWETImport,handleRSSImport.runStats(sqlite happy + pebble empty + unknown-backend error),runGC(with/without paraphrase TTL),runOutcomes(JSON, CSV, bad-format),runStatusFile(missing, bad-JSON, human, JSON, target-reached, stale-warning),runDoctor(local-only human + JSON).go test -short -race ./cmd/cosift/rises from 25.6% → 32.1% (+6.5pp).Test plan
go test -short -race ./cmd/cosift/passes locallygo test -coverprofile