Add self-service verify device-flow via the verifier#301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the self-service verification UX:
pilotctl verify --provider github. The client dials the verifier service over Pilot (PortVerify), runs the OAuth device-flow (prints the user code + URL, polls), receives the KMS-minted badge, and submits it through the daemon (which proves key ownership) to the registry.Pure pilotctl change — uses the driver's existing
Dial+SubmitBadge, no daemon/IPC changes. Speaks pilot-verify's length-prefixed JSONbegin/pollprotocol (one op per connection). Resolves the verifier by literal address or hostname (defaultverify). Device-code instructions print to stderr so JSON stdout stays clean.Also bumps common v0.5.3 → v0.5.5 (both production keys pinned).
Tests
go test -racegreen; gofmt + vet clean.