Fix gitleaks license gate and macOS test TMPDIR in CI#312
Merged
Conversation
security.yml: replace gitleaks/gitleaks-action@v2 (requires a paid GITLEAKS_LICENSE secret for org repos, fails with 'missing gitleaks license') with the MIT-licensed pinned gitleaks binary, matching the rendezvous/common pattern. Scans full history, reads .gitleaks.toml. ci.yml: macOS runners intermittently hand out a RUNNER_TEMP whose permissions break t.TempDir() with 'permission denied'. Create a world-writable subdir under RUNNER_TEMP and point TMPDIR at it on macOS; ubuntu keeps the default.
137b3c0 to
cbf8f31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two CI failures on
main.1.
security.yml— gitleaks "missing gitleaks license"The
gitleaksjob usedgitleaks/gitleaks-action@v2, which requires a paidGITLEAKS_LICENSEsecret for organization repos and fails on push tomainwith missing gitleaks license.Replaced it with the MIT-licensed, version-pinned gitleaks binary (v8.30.1), matching the already-green pattern in
pilot-protocol/rendezvousandpilot-protocol/common:uses: gitleaks/gitleaks-action@v2gitleaks git --no-banner --redact --verbose .Same scan, no license gate. The existing
.gitleaks.tomlallowlist is read by default. Verified locally: full-history scan of this repo reports no leaks found and exits 0; gitleaksgitexits non-zero on real findings.2.
ci.yml— macOS test stepTempDir: permission deniedThe macOS matrix job ("Go (macos-latest)", step "Test (pkg + cmd + internal, -short)") failed with many
TempDir: mkdir /Users/runner/work/_temp/...: permission deniederrors — the recurring GitHub macOS-runner temp-permission issue (also failed pre-existing on #304/#306/#308). The step pointedTMPDIRstraight at${{ runner.temp }}, which is the offending directory.Fix (macOS only; ubuntu unchanged): create a fresh world-writable subdir under
$RUNNER_TEMPand exportTMPDIRto it sot.TempDir()always has a writable base:No tests skipped or deleted; ubuntu job untouched.