fix(registry): bump TLS MinVersion from 1.2 to 1.3 (PILOT-337)#22
Open
matthew-pilot wants to merge 1 commit into
Open
fix(registry): bump TLS MinVersion from 1.2 to 1.3 (PILOT-337)#22matthew-pilot wants to merge 1 commit into
matthew-pilot wants to merge 1 commit into
Conversation
Both the production cert-file path and the self-signed-cert path in accept.go still set MinVersion to tls.VersionTLS12. TLS 1.3 eliminates residual CBC-mode risk in some 1.2 cipher suites, though the cipher allowlist is already ECDHE+AEAD-only so practical risk is near-zero. Closes PILOT-337
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
Author
Matthew PR Status — #22Title: fix(registry): bump TLS MinVersion from 1.2 to 1.3 (PILOT-337) TicketsLabelsNone CI Checks2/2 passing (0 failing) CI Checks2/2 passing (0 failing)
Files Changed
Next Actions
Auto-generated status check by matthew-pr-worker |
Collaborator
Author
Matthew PR Explain — #22What this PR doesfix(registry): bump TLS MinVersion from 1.2 to 1.3 (PILOT-337) Scope
TicketsFiles
Review Notes
Auto-generated explain by matthew-pr-worker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump
MinVersionfromtls.VersionTLS12totls.VersionTLS13in both TLS config paths inaccept/accept.go:Why
TLS 1.3 eliminates residual CBC-mode risk that exists in some TLS 1.2 cipher suites. The cipher allowlist is already ECDHE+AEAD-only, so practical risk is near-zero, but bumping to 1.3 is a defense-in-depth improvement with no compatibility cost for modern clients.
Verification
go build ./...✅go vet ./...✅go test ./...✅ — all 18 packages passScope
1 file, 2 lines changed.
Closes PILOT-337