fix: remove no-op deadline methods from streamAdapter (PILOT-79)#2
Merged
Conversation
Remove SetDeadline, SetReadDeadline, SetWriteDeadline from streamAdapter. These were no-ops that silently returned nil, misleading plugin authors. Depends on the sibling PR in TeoSlayer/pilotprotocol which removes the same methods from the coreapi.Stream interface — merge that PR first, then this one.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the three no-op deadline shims from
streamAdapter:SetDeadlineSetReadDeadlineSetWriteDeadlineUpdates the ceiling test to reflect the interface change.
Why
These methods returned
nilwithout updating any underlying state. Plugin authors calling them believed deadlines were being set — nothing happened.The sibling PR in
TeoSlayer/pilotprotocolremoves these methods from thecoreapi.Streaminterface. The interface change gives callers a compile-time error instead of a silent runtime no-op.Dependencies
TeoSlayer/pilotprotocolPR first — this PR relies on the updatedcoreapi.Streaminterface.Related