refactor: migrate production code to daemonapi v0.4.0#4
Merged
Conversation
Every production .go file now imports common/daemonapi instead of
web4/pkg/daemon. Production code no longer requires web4 at all —
the structural cycle between runtime and the daemon engine is
broken at the import level.
Changes per file:
events.go daemonapi.Event subscription via daemonapi.EventBus
handshake.go HandshakeRuntime adapts daemonapi.Daemon (no longer
*daemon.Daemon) into handshake.Runtime
identity.go Identity / Sign through daemonapi.Daemon
policy.go PolicyRuntime adapts daemonapi.Daemon into
policy.Runtime
policy_manager.go AsDaemonPolicyManager returns daemonapi.PolicyManager
runtime.go Runtime struct holds a daemonapi.Daemon (interface)
streams.go daemonListener uses daemonapi.Listener (Accept +
Port + Close methods); streamAdapter uses
Connection.Info() for endpoint accessors instead
of struct field access
Tests still reference pkg/daemon to spin up real daemons — kept as
a require + replace in go.mod for now; not on the production graph.
Migrating tests to use a fake daemonapi.Daemon implementation is a
follow-up.
go build ($prod) passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production code now imports common/daemonapi instead of web4/pkg/daemon. Cycle structurally broken at the production import level. Tests still reference pkg/daemon for spin-up; that's a follow-up.
🤖 Generated with Claude Code