Call build scripts in the same layer they're needed#143
Merged
brusch merged 3 commits intopimcore:3.xfrom Jul 5, 2023
Merged
Conversation
|
|
jdreesen
approved these changes
Jun 29, 2023
Each `RUN` instruction creates a new layer, so the removed stuff will still remain in the previous layer. This leads to huge image sizes. Before: 3.61GB, max. variant After: 2.78GB, max. variant The code style was slightly changed as well, in order to sort multi-line arguments. See: https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#sort-multi-line-arguments
maxjuergens
force-pushed
the
build-scripts-layer-fix
branch
from
478f651 to
0a08b9a
Compare
lukadschaak
reviewed
Jun 29, 2023
brusch
requested changes
Jul 3, 2023
Contributor
Author
|
@brusch, sure, it makes sense to merge the mentioned |
Contributor
Author
|
@brusch, the Docker Engine used doesn't seem to have version >= 23.0 yet. I've updated the PR and set |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each
RUNinstruction creates a new layer, so the removed stuff will still remain in the previous layer. This leads to huge image sizes.Before: 3.61GB, max. variant
After: 2.78GB, max. variant
The code style was slightly changed as well, in order to sort multi-line arguments.
See: https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#sort-multi-line-arguments