-
Notifications
You must be signed in to change notification settings - Fork 41
Exclude filters in aggregations conditionally #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
|
@jremmurd Could you please rebase this PR to the 2.x branch? There won’t be a 1.4 release. Thanks! |
|
recheck |
|
@jremmurd there are commits in that PR with do not belong to your github user ... eventually you need to add your new e-mail address to your github user. |
|
PR looks good to me. CLA check seems to be fine as well. The failing codeception tests are due to the added secrets, they should run through in the base branch once the pr was merged. |



This PR adds a method to exclude specific filters in the "groupByValues" logic.
There is no breaking change, its just extending the existing possibilities of adjusting the returned aggregation values.
Example:
I have 2 fields which are displayed as one filter in the frontend, lets say sale categories and regular categories. Now I want to exclude the category filter for the sale category filter and vice versa, but I do not want to exclude them for any other filter.
With the new function I now can do something like this: