[Bug, EC] PEES-815: classification type change - generic data index update #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingjia90
reviewed
Oct 29, 2025
Contributor
kingjia90
left a comment
kingjia90
left a comment
There was a problem hiding this comment.
LGTM so far, but haven't reproduced it, i'd just add these extra log to ease debugging
src/Service/SearchIndex/IndexService/IndexHandler/AbstractIndexHandler.php
Outdated
Show resolved
Hide resolved
…xHandler.php Co-authored-by: JiaJia Ji <kingjia90@gmail.com>
kingjia90
reviewed
Oct 29, 2025
src/Service/SearchIndex/IndexService/IndexHandler/AbstractIndexHandler.php
Outdated
Show resolved
Hide resolved
…xHandler.php Co-authored-by: JiaJia Ji <kingjia90@gmail.com>
kingjia90
reviewed
Nov 6, 2025
src/Service/SearchIndex/IndexService/IndexHandler/AbstractIndexHandler.php
Outdated
Show resolved
Hide resolved
|
kingjia90
approved these changes
Nov 7, 2025
Contributor
kingjia90
left a comment
kingjia90
left a comment
There was a problem hiding this comment.
Code-wise LGTM (haven't reproduced it)
robertSt7
deleted the
fix-index-update-after-ClassificationStore-type-change
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves https://github.com/pimcore/service-operations/issues/271
Fix
bin/console generic-data-index:update:indexcommand when change classification type from simple value to object value (numeric => quantity value)