Create CI for testing project creation #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yariksheptykin
force-pushed
the
feature/add-test-workflow
branch
from
c69b2c8 to
bf33e57
Compare
dvesh3
reviewed
Mar 23, 2022
Co-authored-by: Divesh Pahuja <divesh.pahuja@pimcore.com>
Co-authored-by: Divesh Pahuja <divesh.pahuja@pimcore.com>
Contributor
Author
|
Thanks for taking a look at my PR. I addressed your feedback. The PR might be somewhat stale now. If there is interest I can get it up to date. |
Contributor
@yariksheptykin yes, we would like to merge 😉 so please update it. thanks! |
Contributor
|
@yariksheptykin just that you know. we pushed some changes to the PR and now the action is running. |
dvesh3
reviewed
Mar 24, 2022
dvesh3
approved these changes
Mar 28, 2022
Contributor
|
@yariksheptykin New builds will be better with install checks 🚀 thanks a lot!! |
Contributor
|
@yariksheptykin I have created an issue for demo as well pimcore/demo#302. if you like you can provide a PR. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds CI pipeline for smoke-testing this skeleton on PRs and pushed to 10.x branch.
I am not familiar with Github Actions so I tested this CI first on my fork: https://github.com/yariksheptykin/skeleton/actions
To me it seems to do what I want it to do. What I am not sure about is that CI triggers are configured properly. The intentions is to run it on all PRs against 10.x branch and on pushed to 10.x branch. To my surprize this PR does no seem to trigger the CI, which I expected.