fix: use relative path in native contract redirect#471
Merged
Conversation
…me leak Behind a reverse proxy, c.req.url uses the internal http:// scheme. Redirecting with the full URL causes clients to follow an http link instead of https. Use pathname + query only for the redirect target. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
YaroShkvorets
temporarily deployed
to
fix/native-redirect-scheme - token-api PR #471
Render
Destroyed
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the native-address redirect middleware to avoid scheme downgrades when running behind a reverse proxy by redirecting to a relative URL (path + query) instead of a fully-qualified URL.
Changes:
- Build redirect targets as
${pathname}/nativeplus the remaining query string (no scheme/host) for both EVM and SVM middleware. - Extend middleware tests to assert redirects are relative and add test coverage for
nativeMintRedirect.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/middleware/nativeContractRedirect.ts | Switch redirect target construction to relative URLs for both nativeContractRedirect (EVM) and nativeMintRedirect (SVM). |
| src/middleware/nativeContractRedirect.spec.ts | Add assertions that redirects do not include scheme/host and add new tests for nativeMintRedirect. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http://, causing the 302 redirect to downgrade clients fromhttps://tohttp://Affects both EVM (
nativeContractRedirect) and SVM (nativeMintRedirect).🤖 Generated with Claude Code