Conversation
Add handle->pos += *len in shout_file_read() to keep the file position counter in sync after backward seeks. Without this, mpg123_seek() correctly repositions the decoder but subsequent reads never update handle->pos, causing the position to drift and breaking backward seek behavior. This matches the pattern used by other format modules (mod_sndfile, mod_opusfile, mod_native_file) which all update handle->pos in their read functions. Co-authored-by: pinc444 <148037078+pinc444@users.noreply.github.com> Agent-Logs-Url: https://github.com/pinc444/freeswitch/sessions/3063de57-1880-4d2e-b422-c6dea22f6b7f
Copilot
AI
changed the title
[WIP] Fix backward seek issue in MP3 playback
fix(mod_shout): update handle->pos in shout_file_read() to fix backward seek for MP3 files
Mar 24, 2026
pinc444
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shout_file_seek()correctly setshandle->posviampg123_seek(), butshout_file_read()never advanceshandle->posafter reading samples. This causes position tracking to desync after any backward seek, breaking subsequent seek operations.handle->pos += *leninshout_file_read(), consistent with all other format modules (mod_sndfile,mod_opusfile,mod_native_file)⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.