fix(sanity): parse OpenClaw trajectory format correctly#361
Merged
ScuttleBot merged 2 commits intomainfrom Apr 27, 2026
Merged
Conversation
The sanity check grader was looking for type='message' with message.role='assistant', but OpenClaw trajectory files use type='model.completed' with data.assistantTexts[]. This caused ALL models to fail the sanity check with 0%, triggering fail-fast and aborting benchmark runs. Updated the grader to check both model.completed and trace.artifacts entries for assistantTexts, matching the actual trajectory schema.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The fix is clean and correctly addresses the schema mismatch. The new checks properly handle both The new commit only bumps Files Reviewed (2 files)
Reviewed by claude-sonnet-4.6 · 110,925 tokens |
pull Bot
pushed a commit
to Stars1233/skill
that referenced
this pull request
Apr 27, 2026
…hbench#361)" This reverts commit 5e9bc20.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The sanity check grader was looking for
type='message'withmessage.role='assistant', but OpenClaw trajectory files actually usetype='model.completed'withdata.assistantTexts[].This caused ALL models to fail the sanity check with 0%, triggering fail-fast and aborting benchmark runs. We had 42 Vultr instances sitting idle because they all hit this.
Root Cause
Schema mismatch between what the grader expected and what OpenClaw actually produces:
Grader expected:
{"type": "message", "message": {"role": "assistant", "content": [...]}}OpenClaw actually produces:
{"type": "model.completed", "data": {"assistantTexts": ["Hello, I'm ready!..."]}}Fix
Updated the grader to check:
type='model.completed'withdata.assistantTextstype='trace.artifacts'withdata.assistantTexts(final summary)Testing
Verified against actual transcript from a GPT-5.4 run that was incorrectly failing — the model responded correctly but the grader couldn't find the response due to the schema mismatch.