feat(SDK-158): modernize splade-quora notebook to Pinecone SDK v8#543
Open
feat(SDK-158): modernize splade-quora notebook to Pinecone SDK v8#543
Conversation
- Replace 'pinecone-client' package with 'pinecone==8.0.0' - Add getpass fallback for API key per standard pattern - Update markdown content to use timeless, factual language - Consolidate imports into single cell with try-except block - Remove time-sensitive phrases and marketing language - Maintain professional, collegial tone throughout Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernizes
learn/search/semantic-search/sparse/splade/splade-quora.ipynbto use Pinecone SDK v8, bringing it in line with current SDK patterns and content style guidelines.Problem
The SPLADE Quora notebook used the legacy
pinecone-clientpackage and contained time-sensitive language that would become outdated. Import statements were scattered across multiple cells rather than consolidated in a single location.Solution
pinecone-client==3.1.0withpinecone==8.0.0getpassfallback per standard pattern in NOTEBOOK_REVIEW_TEMPLATE.mdKey Changes
pinecone-client[grpc]==3.1.0topinecone[grpc]==8.0.0os.environ.get("PINECONE_API_KEY") or getpass("Enter your Pinecone API key: ")Breaking Changes
None - all functionality remains the same, only package name and import organization changed.
Examples
The notebook demonstrates hybrid search with SPLADE sparse vectors using the Quora dataset. Example queries show how to adjust alpha values to weight sparse vs dense search:
alpha=0.0for pure sparse searchalpha=0.25oralpha=0.6for hybrid searchalpha=1.0for pure dense searchTesting
Audience
Developers implementing semantic search with sparse embeddings, particularly those working with SPLADE models and hybrid search approaches.
Note
Low Risk
Low risk because changes are limited to an example notebook, but the SDK upgrade could break runtime behavior if any v8 API expectations differ from the prior client.
Overview
Modernizes
learn/search/semantic-search/sparse/splade/splade-quora.ipynbby switching dependencies frompinecone-clienttopinecone[grpc]==8.0.0and updating initialization to the v8Pineconeclient.Improves notebook robustness and consistency by consolidating imports into a single guarded cell (with clearer missing-dependency errors), adding a
getpassfallback forPINECONE_API_KEY, and making small copy edits (timeless wording, typo fixes, and minor phrasing around performance guidance).Written by Cursor Bugbot for commit 737cc2e. This will update automatically on new commits. Configure here.