Skip to content

Update config.py #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjaminran merged 2 commits into from
Oct 4, 2021
Merged

Update config.py #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a00a4f
Update config.py
jackpertschuk Oct 1, 2021
4ce2b54
Update config.py
jackpertschuk Oct 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pinecone/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,8 @@ def _preprocess_and_validate_config(self, config: dict) -> dict:
and raises ValueError in case an invalid value was specified.
"""
# general preprocessing and filtering
result = {k.strip(): v.strip() for k, v in config.items() if v is not None}
result = {k: v for k, v in result.items() if k in ConfigBase._fields}
# result = {k.strip(): v.strip() for k, v in config.items() if v is not None}
Copy link
Contributor

@benjaminran benjaminran Oct 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why comment out this line?

Copy link
Contributor Author

@jackpertschuk jackpertschuk Oct 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it throws an error, because v for openapi_config is of type OpenAPI "Configuration", which has no strip() method

Copy link
Contributor Author

@jackpertschuk jackpertschuk Oct 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can fix this however you want

Copy link
Contributor

@benjaminran benjaminran Oct 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, makes sense

result = {k: v for k, v in config.items() if k in ConfigBase._fields}
result.pop('environment', None)
# validate api key
api_key = result.get('api_key')
Expand Down