Conversation
jhamon
force-pushed
the
jhamon/nightly-builds
branch
from
439b8dd to
a49fe56
Compare
damargulis
approved these changes
Jun 8, 2023
rajat08
approved these changes
Jun 8, 2023
micmmakarov
approved these changes
Jun 8, 2023
|
Looks good - just the commented out tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We need a way to consume unreleased changes for integration testing purposes.
Solution
Publish each night, if there are new changes, using the package name
python-client-nightly. This follows the practice of other large projects such astensorflowwhich publishes nightlies under thetf-nightlyname. PyPI does have some limited support for prereleases but releasing a lot of them under our normal package name will make the release history page on pypi look quite cluttered.Type of Change
Test Plan
I successfully used this to publish to testpypi. Just changed a few variables to point at the public index.