Skip to content

Remove pingcap/check and update dependencies#492

Merged
mornyx merged 10 commits intopingcap:masterfrom
dveeden:pingcap_check
Mar 25, 2026
Merged

Remove pingcap/check and update dependencies#492
mornyx merged 10 commits intopingcap:masterfrom
dveeden:pingcap_check

Conversation

@dveeden
Copy link
Copy Markdown
Contributor

@dveeden dveeden commented Feb 27, 2026

What problem does this PR solve?

What is changed and how it works?

  • Remove pingcap/check
  • Replace github.com/pkg/errors with github.com/pingcap/errors
  • Use go.mod in workflows
  • Update actions and OS in workflows
  • Update for the location of the parser (github.com/pingcap/tidb/parsergithub.com/pingcap/tidb/pkg/parser)

Check List

Tests

  • Unit test

@dveeden
Copy link
Copy Markdown
Contributor Author

dveeden commented Feb 27, 2026

/cc @xhebox

@dveeden
Copy link
Copy Markdown
Contributor Author

dveeden commented Feb 27, 2026

/cc @kaaaaaaang

@dveeden dveeden changed the title Remove pingcap/check dependency Remove update dependencies Feb 27, 2026
@dveeden dveeden changed the title Remove update dependencies Remove pingcap/check and update dependencies Feb 27, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 8.50%. Comparing base (82f9593) to head (7335d50).

Files with missing lines Patch % Lines
collector/collect.go 0.00% 2 Missing ⚠️
cmd/diag/command/collect.go 0.00% 1 Missing ⚠️
cmd/diag/command/collectdm.go 0.00% 1 Missing ⚠️
collector/schema.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #492      +/-   ##
=========================================
- Coverage   10.70%   8.50%   -2.20%     
=========================================
  Files         124     124              
  Lines       12591   10402    -2189     
=========================================
- Hits         1347     884     -463     
+ Misses      11073    9363    -1710     
+ Partials      171     155      -16     
Flag Coverage Δ
unittests 8.50% <0.00%> (-2.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dveeden
Copy link
Copy Markdown
Contributor Author

dveeden commented Mar 2, 2026

/cc @kaaaaaaang

@dveeden
Copy link
Copy Markdown
Contributor Author

dveeden commented Mar 19, 2026

/cc @zimulala

@dveeden
Copy link
Copy Markdown
Contributor Author

dveeden commented Mar 19, 2026

/cc @mornyx

@mornyx mornyx merged commit a4ac815 into pingcap:master Mar 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants