Add TiCDC TSO acquisition in sync-diff-inspector doc by teckick · Pull Request #11218 · pingcap/docs-cn

teckick · 2022-09-05T11:45:48Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Add TiCDC TSO acquisition in sync-diff-inspector doc

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

ti-chi-bot · 2022-09-05T11:45:49Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

teckick · 2022-09-05T12:36:47Z

/cc @Reviewer

ti-chi-bot · 2022-09-05T12:36:49Z

@eastfisher: GitHub didn't allow me to request PR reviews from the following users: reviewer.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @Reviewer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

teckick · 2022-09-05T12:40:27Z

/cc @3pointer

teckick · 2022-09-24T12:57:55Z

Why is this PR merged first? #11273

teckick · 2022-09-24T13:03:45Z

@TomShawn

my PR is pending for reviewing but #11273 has been merged which do the similar work.

TomShawn · 2022-09-26T02:19:14Z

Thank you very much for creating this PR and contributing to TiDB documentation. We greatly appreciate your work. The TiCDC syncpoint is an experimental feature. It should have been properly documented as an experimental feature, but to our regret, it is not documented at all. Users cannot find the keyword "syncpoint".

As the TiCDC team plans to make it GA in the upcoming v6.3, they created #11273 to fully introduce the concept of syncpoint, without knowing the existence of this PR. I think this PR should have been reviewed by the TiCDC team @asddongmen instead of @3pointer. Anyway, I think this PR is still a very good complement to #11273. @asddongmen Could you please take a look?

asddongmen · 2022-10-11T06:44:55Z

I'm very sorry for not noticing your PR before. The TiCDC team has improved the syncpoint function and modified some configuration of it. After the work was done, I made changes to this part of the document. Now that the configuration and description of the syncpoint function are different from before, I have modified the content of your PR after review. Thanks a lot for your contribution!

shichun-0415 · 2022-10-11T06:47:09Z

/verify

zier-one

LGTM

shichun-0415 · 2022-10-19T06:02:03Z

/status LGT2

shichun-0415 · 2022-10-19T06:02:17Z

/merge

ti-chi-bot · 2022-10-19T06:02:20Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: e432a72

shichun-0415 · 2022-10-19T08:07:26Z

/verify

shichun-0415 · 2022-10-19T08:13:05Z

/merge

ti-chi-bot · 2022-10-19T08:18:08Z

In response to a cherrypick label: new pull request created: #11691.

* add TiCDC check in sync-diff-inspector * add * Update sync-diff-inspector/upstream-downstream-diff.md * Update sync-diff-inspector/upstream-downstream-diff.md Co-authored-by: dongmen <20351731+asddongmen@users.noreply.github.com> Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>

add TiCDC check in sync-diff-inspector

3b8ded9

ti-chi-bot added the contribution This PR is from a community contributor. label Sep 5, 2022

ti-chi-bot requested a review from TomShawn September 5, 2022 11:45

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 5, 2022

add

dd02713

ti-chi-bot requested a review from 3pointer September 5, 2022 12:40

shichun-0415 added translation/doing This PR’s assignee is translating this PR. area/sync-diff-inspector Indicates that the Issue or PR belongs to the area of sync-diff-inspector. and removed missing-translation-status This PR does not have translation status info. labels Sep 5, 2022

shichun-0415 self-assigned this Sep 5, 2022

TomShawn requested a review from zier-one September 7, 2022 02:27

TomShawn added the area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. label Sep 7, 2022

shichun-0415 added the for-future-release This PR only applies to master for now and might cherry-pick to a future release. label Sep 7, 2022

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2022

TomShawn added type/enhancement The issue or PR belongs to an enhancement. and removed for-future-release This PR only applies to master for now and might cherry-pick to a future release. labels Sep 26, 2022

Merge branch 'master' into dev-sync-diff-cdc-tso

03efc0a

ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 11, 2022

zier-one approved these changes Oct 11, 2022

View reviewed changes

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2022

shichun-0415 reviewed Oct 19, 2022

View reviewed changes

Comment thread sync-diff-inspector/upstream-downstream-diff.md Outdated

Update sync-diff-inspector/upstream-downstream-diff.md

e432a72

shichun-0415 approved these changes Oct 19, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 19, 2022

ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 19, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 19, 2022

shichun-0415 added the needs-cherry-pick-release-6.3 label Oct 19, 2022

shichun-0415 reviewed Oct 19, 2022

View reviewed changes

Comment thread sync-diff-inspector/upstream-downstream-diff.md

Update sync-diff-inspector/upstream-downstream-diff.md

0c7239d

shichun-0415 merged commit 0d4124b into pingcap:master Oct 19, 2022

ti-chi-bot mentioned this pull request Oct 19, 2022

Add TiCDC TSO acquisition in sync-diff-inspector doc (#11218) #11691

Merged

13 tasks

ti-chi-bot added a commit that referenced this pull request Oct 19, 2022

Add TiCDC TSO acquisition in sync-diff-inspector doc (#11218) (#11691)

7609861

This was referenced Oct 19, 2022

Update sync diff pingcap/docs#10903

Closed

Add TiCDC TSO acquisition in sync-diff-inspector doc pingcap/docs#10904

Merged

ti-chi-bot mentioned this pull request Oct 20, 2022

Add TiCDC TSO acquisition in sync-diff-inspector doc (#10904) pingcap/docs#10927

Merged

14 tasks

shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Oct 20, 2022

Conversation

teckick commented Sep 5, 2022 • edited by shichun-0415 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

ti-chi-bot commented Sep 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

teckick commented Sep 5, 2022

Uh oh!

ti-chi-bot commented Sep 5, 2022

Uh oh!

teckick commented Sep 5, 2022

Uh oh!

teckick commented Sep 24, 2022

Uh oh!

teckick commented Sep 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TomShawn commented Sep 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

asddongmen commented Oct 11, 2022

Uh oh!

shichun-0415 commented Oct 11, 2022

Uh oh!

zier-one left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shichun-0415 commented Oct 19, 2022

Uh oh!

shichun-0415 commented Oct 19, 2022

Uh oh!

ti-chi-bot commented Oct 19, 2022

Uh oh!

shichun-0415 commented Oct 19, 2022

Uh oh!

Uh oh!

shichun-0415 commented Oct 19, 2022

Uh oh!

ti-chi-bot commented Oct 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

teckick commented Sep 5, 2022 •

edited by shichun-0415

Loading

ti-chi-bot commented Sep 5, 2022 •

edited

Loading

teckick commented Sep 24, 2022 •

edited

Loading

TomShawn commented Sep 26, 2022 •

edited

Loading