Skip to content

credits: remove outdated contributor link and repos#13776

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
lilin90:remove-credits-link
Apr 24, 2023
Merged

credits: remove outdated contributor link and repos#13776
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
lilin90:remove-credits-link

Conversation

@lilin90
Copy link
Member

@lilin90 lilin90 commented Apr 24, 2023 •
edited
Loading

What is changed, added or deleted? (Required)

  • Remove an outdated link of contributors, which does not work now
  • Update the list of repos because multiple repos have been combined or migrated to another repo
    Note: All the changed will be cherry picked to v6.5, v6.6, v7.0 according to the repo archive date, while the change of removing the outdated contributor link will be cherry picked to all selected versions. The docs-dm repo link will be kept for v5.3 and earlier versions.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lilin90 lilin90 added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Apr 24, 2023
@lilin90 lilin90 requested a review from Oreoxmt April 24, 2023 06:24
@lilin90 lilin90 self-assigned this Apr 24, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 24, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 24, 2023
Oreoxmt
Oreoxmt approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 24, 2023
@lilin90
Copy link
Member Author

lilin90 commented Apr 24, 2023

@Oreoxmt Thanks for your review. And I added another commit to remove outdated repo links and added some explanation to the PR description box. PTAL again, thanks!

Oreoxmt
Oreoxmt approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 changed the title credits: remove an outdated contributor link credits: remove outdated contributor link and repos Apr 24, 2023
@lilin90 lilin90 added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 24, 2023
@lilin90
Copy link
Member Author

lilin90 commented Apr 24, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 24, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 863097f

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 24, 2023
@ti-chi-bot ti-chi-bot bot merged commit 1090197 into pingcap:master Apr 24, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 24, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 24, 2023

In response to a cherrypick label: new pull request created to branch release-5.0: #13782.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 24, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 24, 2023

In response to a cherrypick label: new pull request created to branch release-5.3: #13783.

@lilin90 lilin90 deleted the remove-credits-link branch April 24, 2023 07:14
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 24, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 24, 2023

In response to a cherrypick label: new pull request created to branch release-5.2: #13787.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 24, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 24, 2023

In response to a cherrypick label: new pull request created to branch release-5.4: #13788.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 24, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 24, 2023

In response to a cherrypick label: new pull request created to branch release-6.5: #13789.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 24, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 24, 2023

In response to a cherrypick label: new pull request created to branch release-6.6: #13790.

ti-chi-bot bot pushed a commit that referenced this pull request Apr 24, 2023
@ti-chi-bot @lilin90
credits: remove outdated contributor link and repos (#13776) (#13789)
39721a8 
* credits: remove an outdated contributor link

* credits: remove outdated repos

---------

Co-authored-by: Lilian Lee <lilin@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this pull request Apr 24, 2023
@ti-chi-bot @lilin90
credits: remove outdated contributor link and repos (#13776) (#13783)
31d9c79 
* credits: remove an outdated contributor link

* credits: remove outdated repos

* Update credits.md

---------

Co-authored-by: Lilian Lee <lilin@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this pull request Apr 24, 2023
@ti-chi-bot @lilin90
credits: remove outdated contributor link and repos (#13776) (#13790)
2236b7d 
* credits: remove an outdated contributor link

* credits: remove outdated repos

---------

Co-authored-by: Lilian Lee <lilin@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this pull request Apr 24, 2023
@ti-chi-bot @lilin90
credits: remove outdated contributor link and repos (#13776) (#13785)
5e00c80 
* credits: remove an outdated contributor link

* credits: remove outdated repos

---------

Co-authored-by: Lilian Lee <lilin@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this pull request Apr 24, 2023
@ti-chi-bot @lilin90
credits: remove outdated contributor link and repos (#13776) (#13788)
4f0e996 
* credits: remove an outdated contributor link

* credits: remove outdated repos

* Update repo links

---------

Co-authored-by: Lilian Lee <lilin@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this pull request Apr 24, 2023
@ti-chi-bot @lilin90
credits: remove outdated contributor link and repos (#13776) (#13787)
4bc7ebd 
* credits: remove an outdated contributor link

* credits: remove outdated repos

* Update credits.md

---------

Co-authored-by: Lilian Lee <lilin@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this pull request Apr 24, 2023
@ti-chi-bot @lilin90
credits: remove outdated contributor link and repos (#13776) (#13784)
462cc88 
* credits: remove an outdated contributor link

* credits: remove outdated repos

* Update repo links

---------

Co-authored-by: Lilian Lee <lilin@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this pull request Apr 24, 2023
@ti-chi-bot @lilin90
credits: remove outdated contributor link and repos (#13776) (#13786)
3bb535d 
* credits: remove an outdated contributor link

* credits: remove outdated repos

* Update credits.md

---------

Co-authored-by: Lilian Lee <lilin@pingcap.com>
lilin90 added a commit that referenced this pull request Apr 24, 2023
@ti-chi-bot @lilin90
credits: remove outdated contributor link and repos (#13776) (#13782)
71b9070 
* credits: remove an outdated contributor link

* credits: remove outdated repos

* Update credits.md

---------

Co-authored-by: Lilian Lee <lilin@pingcap.com>
@lilin90 lilin90 mentioned this pull request Apr 24, 2023
Merged
15 tasks
@lilin90 lilin90 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 24, 2023
This was referenced Apr 25, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@lilin90 lilin90

Labels

needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lilin90 @ti-chi-bot @Oreoxmt